Enable cross-crate incremental compilation by default. #42055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -963,7 +963,7 @@ options! {DebuggingOptions, DebuggingSetter, basic_debugging_options, | |||
| "attempt to recover from parse errors (experimental)"), | |||
| incremental: Option<String> = (None, parse_opt_string, [UNTRACKED], | |||
| "enable incremental compilation (experimental)"), | |||
| incremental_cc: bool = (false, parse_bool, [UNTRACKED], | |||
| incremental_cc: bool = (true, parse_bool, [UNTRACKED], | |||
There was a problem hiding this comment.
should we just remove the option altogether?
|
@bors r+ |
|
📌 Commit af0c900 has been approved by |
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
May 17, 2017
…al-cc, r=nikomatsakis Enable cross-crate incremental compilation by default. Now that direct metadata hashing has been implemented for a while and we haven't seen any problems with it over at [rust-icci](https://travis-ci.org/rust-icci/), let's re-enable cross crate support for incremental compilation again. r? @nikomatsakis
aidanhs
added
the
S-waiting-on-bors
|
☔ The latest upstream changes (presumably #41911) made this pull request unmergeable. Please resolve the merge conflicts. |
|
🔒 Merge conflict |
michaelwoerister
force-pushed
the
reenable-incremental-cc
branch
from
af0c900 to
1b8df3d
Compare
|
@bors r=nikomatsakis |
|
📌 Commit 1b8df3d has been approved by |
|
⌛ Testing commit 1b8df3d with merge 4ec4be4... |
|
💔 Test failed - status-travis |
|
@bors retry |
bors
added a commit
that referenced
this pull request
May 18, 2017
…komatsakis Enable cross-crate incremental compilation by default. Now that direct metadata hashing has been implemented for a while and we haven't seen any problems with it over at [rust-icci](https://travis-ci.org/rust-icci/), let's re-enable cross crate support for incremental compilation again. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that direct metadata hashing has been implemented for a while and we haven't seen any problems with it over at rust-icci, let's re-enable cross crate support for incremental compilation again.
r? @nikomatsakis